Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More missing landscape classifications for SLE project #2006

Open
wants to merge 43 commits into
base: dev
Choose a base branch
from

Conversation

ColinHDev
Copy link
Member

@ColinHDev ColinHDev commented Dec 22, 2024

Type of change (CHANGELOG.md)

This comes from #1962 and is a follow-up PR from #1991

Add

  • Added WHG as an instance of legislation
    • definition: The WHG is a legislation providing the legal framework for water management in Germany.
  • Added BWaldG as an instance of legislation
    • definition: The BWaldG is a legislation providing the legal framework for the preservation of forests and the promotion of forestry in Germany.

  • Added biosphere reserve role as a subclass of protected area role and 'is defined by' value BNatSchG
    • definition: A biosphere reserve role is a protected area role for areas, aimed at conserving biodiversity, promoting sustainable development, and supporting research and education, within the UNESCO "Man and the Biosphere" (MAB) Programme.
  • Added protected landscape area role as a subclass of protected area role and 'is defined by' value BNatSchG
    • definition: A protected landscape area role is a protected area role for areas, aimed at conserving and enhancing the natural and cultural landscape, while allowing for sustainable land use and recreational activities.
  • Added water protection area role as a subclass of protected area role and 'is defined by' value WHG
    • definition: A water protection area role is a protected area role for areas, aimed at safeguarding the quality and quantity of water resources, including surface water and groundwater.
  • Added floodplain role as a subclass of role and 'is defined by' value WHG
    • definition: A floodplain role is a role for areas between surface waters and dykes or high banks and other areas that are flooded or flowed through during flooding of a surface water body or that are used for flood relief or retention.
  • Added forest role as a subclass of role and 'is defined by' value BWaldG
    • definition: A forest role is a role for areas planted with forest plants as well as clear-cut or thinned ground areas, forest paths, forest division and safety strips, forest openings and clearings, forest meadows, game grazing areas, wood storage areas and other areas connected to and serving the forest.
  • Added soil quality role as a subclass of role
    • definition: A soil quality role is a role inherent in a region of relevance reflecting how well a soil, that is part of the bearer, performs the functions of maintaining biodiversity and productivity, partitioning water and solute flow, filtering and buffering, nutrient cycling, and providing support for plants and other structures.
  • Added high soil quality role as a subclass of soil quality role
    • definition: A high soil quality role is a soil quality role inherent in a region of relevance reflecting that the soil, that is part of the bearer, has a high soil quality.
  • Added poor soil quality role as a subclass of soil quality role
    • definition: A poor soil quality role is a soil quality role inherent in a region of relevance reflecting that the soil, that is part of the bearer, has a poor soil quality.

  • Added biosphere reserve as an equivalent class of 'protected area' that 'has role' some 'biosphere reserve role'
    • definition: A biosphere reserve is a protected area that has the biosphere reserve role, i.e. it is protected for conserving biodiversity, promoting sustainable development, and supporting research and education, within the UNESCO "Man and the Biosphere" (MAB) Programme.
  • Added protected landscape area as an equivalent class of 'protected area' that 'has role' some 'protected landscape area role'
    • definition: A protected landscape area is a protected area that has the protected landscape area role, i.e. it is aimed at conserving and enhancing the natural and cultural landscape, while allowing for sustainable land use and recreational activities.
  • Added water protection area as an equivalent class of 'protected area' that 'has role' some 'water protection area role'
    • definition: A water protection area is a protected area that has the water protection area role, i.e. it is aimed at safeguarding the quality and quantity of water resources, including surface water and groundwater.
  • Added floodplain as an equivalent class of 'region of relevance' that 'has role' some 'floodplain role'
    • definition: A floodplain is a region of relevance that has the floodplain role, i.e. for areas between surface waters and dykes or high banks and other areas that are flooded or flowed through during flooding of a surface water body or that are used for flood relief or retention.
  • Added forest as an equivalent class of 'region of relevance' that 'has role' some 'forest role'
    • definition: A forest is a region of relevance that has the forest role, i.e. it is planted with forest plants as well as clear-cut or thinned ground areas, forest paths, forest division and safety strips, forest openings and clearings, forest meadows, game grazing areas, wood storage areas and other areas connected to and serving the forest.
  • Added arable land as an equivalent class of 'region of relevance' that 'has role' some 'soil quality role'
    • definition: An arable land is a region of relevance which is regularly manipulated by human activities, such as plowing or tilling, in order to grow crops.
  • Added arable land with high soil quality as an equivalent class of 'arable land' that 'has role' some 'high soil quality role'
    • definition: An arable land with high soil quality is an arable land having some soil as part that can be categorized as having high soil quality.
  • Added arable land with poor soil quality as an equivalent class of 'arable land' that 'has role' some 'poor soil quality role'
    • definition: An arable land with poor soil quality is an arable land having some soil as part that can be categorized as having poor soil quality.

Update

---

Remove

---

Workflow checklist

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-model changes the oeo-model module label Dec 22, 2024
@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Feb 1, 2025
…ations' into feature-1962-landscape-classifications-v2
@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label Feb 7, 2025
@ColinHDev ColinHDev marked this pull request as ready for review February 9, 2025 20:52
@github-actions github-actions bot added the oeo-physical changes the oeo-physical module label Feb 9, 2025
@ColinHDev ColinHDev marked this pull request as draft February 9, 2025 21:05
@stap-m
Copy link
Contributor

stap-m commented Feb 10, 2025

@LillyG901 please also have a look. Once we have an agreement, we should check with ENVO for potential mappings/imports, tool

@stap-m
Copy link
Contributor

stap-m commented Feb 14, 2025

@ColinHDev The idea of the oeo workflow is to discuss all new entities, definitions, axioms,... in an issue first and implement afterwards in the PR. Just as a reminder for next time...

You added the definition souces to the roles, which is great. I think it is helpful for users to add them to the instances as well. Furthermore, the explainations from the role definitions would be of value added to the definitions of the instances as well, see my exemplary suggestion in the code.

@ColinHDev ColinHDev marked this pull request as ready for review March 3, 2025 10:09
@ColinHDev ColinHDev requested a review from stap-m March 3, 2025 13:45
Base automatically changed from feature-1962-landscape-classifications to dev March 6, 2025 11:36
@stap-m stap-m added this to the oeo-release-2.8.0 milestone Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module
Projects
Status: Review in progress
Development

Successfully merging this pull request may close these issues.

2 participants